[wix-devs] v4.0 - status check/where to jump in

[Sean Hall]

It looks like moving WixCop into the Tools repo is a good way to get
started. I'm going to start working on that.

On Wed, Aug 29, 2018 at 12:30 PM Bob Arnson <bob at firegiant.com> wrote:

> I’m not blocked by any of the WixCop bugs I opened.
>
>
>
> I’m not sure whether Rob intends to keep Converter in Core. It’s in kind
> of the same boat as Dark and Heat. If it’s not shared (and if it doesn’t
> need a bunch of internals), they might move entirely to Tools.
>
>
>
> We could run everything through it (e.g., `wix harvest`) but currently,
> it’s only available as a .NET Core “global tool” so you have to install it
> using dotnet.exe. (I’ve built it manually to run on .NET Framework.) I’m
> not entirely sure whether Rob’s being crazy-smart or just crazy with the
> global tool idea. Generally, we think 98% of people are going to get the
> tools via the MSBuild NuGet package and won’t see the old set of
> command-line .exes.
>
>
>
> *From:* Sean Hall <r.sean.hall at gmail.com>
> *Sent:* Tuesday, 28 August, 2018 22:54
> *To:* Bob Arnson <bob at firegiant.com>
> *Subject:* Re: [wix-devs] v4.0 - status check/where to jump in
>
>
>
> This is partly why I was asking what was currently being worked on. I can
> pick up moving WixCop if you're not doing it but I didn't want to block you
> from doing what you were thinking of picking up.
>
>
>
> I looked around, and it looks like most of the work of WixCop is being
> done in Core/src/WixToolset.core/Converter.cs. Which Rob recently made
> internal, so that's something that needs to be addressed. I think we're
> supposed to make it implement an interface and get an instance from
> IServiceProvider?
>
>
>
> Is everything supposed to move into wix.exe? So this would be "wix
> convertToV4 ..."? Or is WixCop still going to be standalone?
>
>
>
> I'm still not sure what I'm going to pick up. If we're just doing things
> in the v4.0 milestone, I would just as soon work on this bug that
> apparently got assigned to me:
> https://github.com/wixtoolset/issues/issues/5410.
>
> On Tue, Aug 28, 2018 at 7:41 PM Bob Arnson <bob at firegiant.com> wrote:
>
> Feel free to take any of these:
> https://github.com/wixtoolset/issues/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3Av4.0+assignee%3Abarnson+
>
> Or a couple that might be interesting (he says being the one to open them):
>
> https://github.com/wixtoolset/issues/issues/4559
> https://github.com/wixtoolset/issues/issues/5649
> https://github.com/wixtoolset/issues/issues/5652
>
> The latter two of which point to a good area: WixCop. I was going to move
> it into the Tools repo but if you wanted to do that, I'm happy to pick up
> other stuff. WixCop could use some love, though I've put a significant
> amount of WiX v3 code through it lately with good results.
>
> -----Original Message-----
> From: wix-devs <wix-devs-bounces at lists.wixtoolset.org> On Behalf Of Sean
> Hall via wix-devs
> Sent: Tuesday, 28 August, 2018 20:08
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Cc: Sean Hall <r.sean.hall at gmail.com>
> Subject: Re: [wix-devs] v4.0 - status check/where to jump in
>
> I was hoping for a more specific task like "fix this bug" or "create this
> micro repo".
>
>