[wix-devs] WIX 4

[Hoover, Jacob]

390 looks like you made the fix in one branch but requested it to be merged in another (really it looks like you just requested develop to be merged into master). Rob/Bob can chime in, but I am betting they will want a PR that is clean with a single commit to develop. I wasn't able to find a change of yours in the PR.

393 looks better.

We've been leaning towards wanting the PR's to happen in 4.0 and then to be back ported to 3.x but in this case 393 doesn't look that "bad".  Best bet would be to join in for the next online meeting so we can quickly chat and get a direction/feedback to you.

Thanks again for your contribution.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Fyodor Koryazhkin
Sent: Thursday, January 26, 2017 9:21 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: [wix-devs] WIX 4

Hi,
Recently I have opened two pull requests (#390 and #393) for WIX 3.x Should I do the same thing for WIX 4 or all fixes will be merged to it automatically later?

--
Regards,
Fyodor Koryazhkin..
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/