[wix-devs] Bug #3813 Wrong binding in IIS site

[John Cooper]

Yes, it would have some impact.  Some of my custom actions modify the bindings and rely on certain states that the IIS extension leaves them in.  It would not be difficult to change them, but it would impact most of our products.

--
John Merryweather Cooper
Senior Software Engineer -- Integration Development Group -- Enterprise Notification Service
Jack Henry & Associates, Inc.® | Lenexa, KS  66214 | Office:  913-341-3434x431050
JoCooper at jackhenry.com




-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Fyodor Koryazhkin
Sent: Wednesday, January 18, 2017 4:42 AM
To: wix-devs at lists.wixtoolset.org
Subject: [wix-devs] Bug #3813 Wrong binding in IIS site

The e-mail below is from an external source.  Please do not open attachments or click links from an unknown or suspicious origin.

Hi,
This defect is really disturbing us preventing from getting new versions and I want to contribute the fix that we implemented locally.

The issue is that if you create binding manually then Windows put the star
(*) in the field IP address meaning for all unassigned addresses. From the other hand WIX IIS extension custom action puts empty string for all unassigned addresses. This creates two entries with the same port in binding causing WEB site not to start/ crash.

The current code replaces the star with empty string.
My suggestion is to do the opposite: replace empty string (IIS schema allows not to specify IP Port in Address element) with the star. Thus it will prevent creating the second entry in binding for the same port.

Will this affect some other areas?

--
Regards,
Fyodor Koryazhkin..
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/

NOTICE: This electronic mail message and any files transmitted with it are intended
exclusively for the individual or entity to which it is addressed. The message, 
together with any attachment, may contain confidential and/or privileged information.
Any unauthorized review, use, printing, saving, copying, disclosure or distribution 
is strictly prohibited. If you have received this message in error, please 
immediately advise the sender by reply email and delete all copies.