Jacob.Hoover at greenheck.com
Mon Feb 13 08:27:48 PST 2017
So did we just miss closing https://github.com/wixtoolset/issues/issues/5334 ?
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Sean Hall
Sent: Monday, February 13, 2017 10:24 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] WIXBUG5334
You can look at an individual commit and GitHub will show pull requests containing that commit. For example, go to
and you can see the pull request between the commit message and "jchoover committed on Jul 10, 2016". In this case, https://github.com/wixtoolset/wix3/pull/369, which appears to be merged already.
On Mon, Feb 13, 2017 at 10:17 AM, Hoover, Jacob <Jacob.Hoover at greenheck.com>
> Was hammering out my backlog over the weekend and I had some serious
> deja vu on this issue. Waited until I got access to my work PC and lo
> and behold I had done this a long while back. I also see I committed
> an update to it per a code review, but for the life of me I can't find
> the original pull request.
> My fix is here: https://github.com/jchoover/wix3/tree/WIXBUG5334 and
> was wondering if there was any github expert that could tell me of a
> way to find a missing PR. Otherwise I can just resubmit the PR.
> WiX Toolset Developer Mailing List provided by FireGiant
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/
More information about the wix-devs