[wix-devs] OnExecutePackageComplete without OnExecutePackageBegin

[Heath Stewart]

Sounds good. That did ring a bell once mentioned and sounds better. I definitely wasn't crazy about skipping potential additional clean-up in LExit someday in the future.

Heath Stewart
Visual Studio, Microsoft
http://blogs.msdn.com/heaths


-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Bob Arnson
Sent: Thursday, March 17, 2016 10:37 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] OnExecutePackageComplete without OnExecutePackageBegin

EngineRun wins as best example.

> -----Original Message-----
> From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On 
> Behalf Of Rob Mensching
> Sent: Thursday, 17 March, 2016 13:35
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Subject: Re: [wix-devs] OnExecutePackageComplete without 
> OnExecutePackageBegin
> 
> And in that unusual case, as Sean points out, to control it (if 
> necessary) a bool is usually introduced.
> 
> __________________________________________________________
> _____
>  FireGiant  |  Dedicated support for the WiX toolset  | 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.fi
> regiant.com%2f&data=01%7c01%7cHeath.Stewart%40microsoft.com%7cd8d5b562
> aef5496c667208d34e8ac3a6%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> gY2L0POFubCIoB5gjG8bsV%2bT4UySZLXMolyMoqrsWdY%3d
> 
> 
> -----Original Message-----
> From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On 
> Behalf Of Bob Arnson
> Sent: Thursday, March 17, 2016 10:33 AM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Subject: Re: [wix-devs] OnExecutePackageComplete without 
> OnExecutePackageBegin
> 
> All the Release* macros do that, just using NULL or some other value 
> instead of an extra BOOL. If anything, the "do real work in LExit" is the unusual case.
> 
> > -----Original Message-----
> > From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On 
> > Behalf Of Sean Hall
> > Sent: Thursday, 17 March, 2016 13:28
> > To: WiX Toolset Developer Mailing List 
> > <wix-devs at lists.wixtoolset.org>
> > Subject: Re: [wix-devs] OnExecutePackageComplete without 
> > OnExecutePackageBegin
> >
> > I believe there is already precedence in burn to have a boolean 
> > initially set to false, then set to true once something happened.  
> > In LExit, it then performs additional work if it was set to true.
> >
> __________________________________________________________
> __________
> WiX Toolset Developer Mailing List provided by FireGiant 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.fi
> regiant.com%2f&data=01%7c01%7cHeath.Stewart%40microsoft.com%7cd8d5b562
> aef5496c667208d34e8ac3a6%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=
> gY2L0POFubCIoB5gjG8bsV%2bT4UySZLXMolyMoqrsWdY%3d
____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fwww.firegiant.com%2f&data=01%7c01%7cHeath.Stewart%40microsoft.com%7cd8d5b562aef5496c667208d34e8ac3a6%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=gY2L0POFubCIoB5gjG8bsV%2bT4UySZLXMolyMoqrsWdY%3d