[wix-devs] FeedBuilder

Bob Arnson bob at firegiant.com
Tue Jul 19 08:28:14 PDT 2016


More granular, think like "dutil" and "dtf" repos. But yeah, that gets harder when cross-repo changes are needed...

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Monday, 18 July, 2016 12:36
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] FeedBuilder

As in having a wix3-ext repo where we could add functionality.  Part of the issue is I was going to rely on an internal class BundleReader/BundleCore and add the small bits needed to include the BundleId as a property.

Ex:
public Guid BundleId { get; protected set; }

protected bool Initialize(BinaryReader reader) { ...
this.BundleId = BurnCommon.ReadGuid(bytes, BURN_SECTION_OFFSET_BUNDLEGUID); ...
}

            /// <summary>
            /// Reads a Guid value in from an offset in an array of bytes.
            /// </summary>
            /// <param name="bytes">Array from which to read.</param>
            /// <param name="offset">Beginning offset from which to read.</param>
            /// <returns>value at offset</returns>
            private static Guid ReadGuid(byte[] bytes, UInt32 offset)
            {
                Debug.Assert(offset + 16 <= bytes.Length);
                byte[] buffer = new byte[16];
                Array.Copy(bytes, offset, buffer, 0, 16);
                return new Guid(buffer);
            }

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Bob Arnson
Sent: Saturday, July 16, 2016 4:49 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] FeedBuilder

It's ancient -- 8+ years old. And it doesn't look like it's used, just included. Rather than add it to v3.11, what about making it its own repo? That's where we're leaning toward libraries and such.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Thursday, 14 July, 2016 11:35
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: [wix-devs] FeedBuilder

Rob/Bob/Sean,
  It looks like we have some leftover bits from the old click once stuff in the toolset (ambient I believe).  I'm currently in process of fully automating my installation builds, and I've got some interest in the FeedBuilder logic and how it could be repurposed into a MSBuild task that I could tie into my bundle builds.  Am I right in the observation that these bits are leftover, and would you agree in this being potentially useful?  Would you consider accepting a task in 3.11 if I were to do an implementation?

Thanks,
Jacob

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/


More information about the wix-devs mailing list