[wix-devs] Clean room defect with 3.11.2 - /layout

Hoover, Jacob Jacob.Hoover at greenheck.com
Thu Jan 28 10:34:49 PST 2016


That's with my changes or without?

In my PR I had changed LayoutBundle to include that check via:

    hr = VariableGetString(pVariables, BURN_BUNDLE_SOURCE_PROCESS_PATH, &sczBundleSourcePath);
    ExitOnFailure(hr, "Failed to get path to bundle source process path to layout.");
...
    // If the destination path is the currently running bundles source process, bail.
    hr = PathCompare(sczBundleSourcePath, sczDestinationPath, &nEquivalentPaths);
    ExitOnFailure(hr, "Failed to determine if layout bundle path was equivalent with source process path.");

    if (CSTR_EQUAL == nEquivalentPaths)
    {
        ExitFunction1(hr = S_OK);
    }

Which should account for that.


-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of John Cooper
Sent: Thursday, January 28, 2016 12:31 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout

Get the directory part of WixBundleSourceProcessPath does work.  I get a file in use error during layout if WixBundleLayoutDirectory equals this path though.

--
John Merryweather Cooper
Senior Software Engineer | Integration Development Group | Enterprise Notification Service Jack Henry & Associates, Inc.® | Lenexa, KS  66214 | Ext:  431050 |JoCooper at jackhenry.com




-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of John Cooper
Sent: Thursday, January 28, 2016 11:48 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout

The e-mail below is from an external source.  Please do not open attachments or click links from an unknown or suspicious origin.

Passing the path to -layout does work.  I'll test WixBundleSourceProcessPath.

--
John Merryweather Cooper
Senior Software Engineer | Integration Development Group | Enterprise Notification Service Jack Henry & Associates, Inc.® | Lenexa, KS  66214 | Ext:  431050 |JoCooper at jackhenry.com




-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Rob Mensching
Sent: Thursday, January 28, 2016 11:29 AM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout

The e-mail below is from an external source.  Please do not open attachments or click links from an unknown or suspicious origin.

Sigh. Bigger sigh. 

I know we tested this, at least, once... but probably before fixing XP or something.  

Sigh.

Can't use WixOriginalSource. That could be set to wrong place if bundle is already installed. Probably just need to add WixBundleSourceProcessPath to the default layout directory.

Fortunately, if you do "-layout path\for\layout" that should still work (haven't tested it today, yet). Maybe that's what was tested and the default wasn't.

Sigh.

_______________________________________________________________
 FireGiant  |  Dedicated support for the WiX toolset  |  http://www.firegiant.com/


-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of John Cooper
Sent: Wednesday, January 27, 2016 1:20 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout

Makes sense since the executable is now running from a different  location from OriginalSource.  May need to use WixOriginalSource instead of a call to CurrentDirectory.

--
John Merryweather Cooper
Senior Software Engineer | Integration Development Group | Enterprise Notification Service Jack Henry & Associates, Inc.® | Lenexa, KS  66214 | Ext:  431050 |JoCooper at jackhenry.com




-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Wednesday, January 27, 2016 3:08 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: [wix-devs] Clean room defect with 3.11.2 - /layout

The e-mail below is from an external source.  Please do not open attachments or click links from an unknown or suspicious origin.

It seems layout is broken with 3.10.2, as the payload goes to the .cr instead of the original exe location.  Can anyone else confirm this?

Thanks,
Jacob

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/

NOTICE: This electronic mail message and any files transmitted with it are intended exclusively for the individual or entity to which it is addressed. The message, together with any attachment, may contain confidential and/or privileged information.
Any unauthorized review, use, printing, saving, copying, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email and delete all copies.

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/

NOTICE: This electronic mail message and any files transmitted with it are intended exclusively for the individual or entity to which it is addressed. The message, together with any attachment, may contain confidential and/or privileged information.
Any unauthorized review, use, printing, saving, copying, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email and delete all copies.

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/

NOTICE: This electronic mail message and any files transmitted with it are intended exclusively for the individual or entity to which it is addressed. The message, together with any attachment, may contain confidential and/or privileged information.
Any unauthorized review, use, printing, saving, copying, disclosure or distribution is strictly prohibited. If you have received this message in error, please immediately advise the sender by reply email and delete all copies.

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/


More information about the wix-devs mailing list