[wix-devs] Clean room defect with 3.11.2 - /layout [P]

Wed Jan 27 14:29:14 PST 2016

I probably won't make the Friday meeting either, but thanks for your help Jacob.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Wednesday, January 27, 2016 4:27 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout [P]

https://github.com/wixtoolset/wix3/pull/325

Sadly we've already forked develop to be 3.11, but it's a rather small/clean commit (sorry I forgot a history entry / bug report) so we may wish to consider a 3.10.3.  Sadly I don't think I am going to be able to make this Fridays meeting.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Wednesday, January 27, 2016 3:57 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout [P]

Yep,
  Same thing as I am seeing.  The second change should get most of the content, but I am having issues with LayoutBundle, as it doesn't have variables passed to it....  This is all internal though, so I believe we can change the signature without impacting anyone.

I'll cherry pick my commit and get a pull request in place, though I am not certain I've hit every location.  I've also noticed a bug where the Original bundle name is used from the manifest, instead of using the name of the source executable (but that may have existed and I am not trying to fix for this commit).

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Steven Ogilvie
Sent: Wednesday, January 27, 2016 3:36 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout [P]

Classification: Public
BTW did test it with putting a path, which did work as expected...

Ran:
C:\Temp\admin>TITUSIlluminateSetup.exe /layout C:\Temp\admin\bob

Package was placed in C:\Temp\admin\bob

Logfile:
Burn v3.10.2.2522, Windows v6.1 (Build 7601: Service Pack 1), path: C:\Users\STEVEN~1.OGI\AppData\Local\Temp\{0E2BE6E3-7479-4B10-8E66-2028458166A4}\.cr\TITUSIlluminateSetup.exe
...
Command Line: '-burn.clean.room=C:\Temp\admin\TITUSIlluminateSetup.exe /layout C:\Temp\admin\bob'
'WixBundleOriginalSource' to value 'C:\Temp\admin\TITUSIlluminateSetup.exe'
'WixBundleOriginalSourceFolder' to value 'C:\Temp\admin\'
...
'WixBundleLayoutDirectory' to value 'C:\Temp\admin\bob'
...
Acquiring bundle payload: , copy from: C:\Users\STEVEN~1.OGI\AppData\Local\Temp\{0E2BE6E3-7479-4B10-8E66-2028458166A4}\.cr\TITUSIlluminateSetup.exe
Layout bundle from: 'C:\Users\STEVEN~1.OGI\AppData\Local\Temp\{FDD3C3BB-0D2C-433D-9045-8B2701BD12DD}\{a9a99aa2-42d0-4e3c-a83a-cf923dfc0a2e}' to: 'C:\Temp\admin\bob\TITUSIlluminateSetup.exe'

Cheers,

Steve

This message has been marked as Public by Steven Ogilvie on January-27-16 4:36:23 PM.

The above classification labels were added to the message by TITUS Message Classification. 
For more information visit www.titus.com.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: January-27-16 4:31 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout 

apply.cpp
 - LayoutBundle : should also check origional location?

plan.cpp
 - PlanLayoutBundle: PathForCurrentProcess should be changed to WixOriginalSource?

I think the plan part would be the quick fix, and the apply part is just for sanity (otherwise it will get a sharing violation).

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Phill Hogland
Sent: Wednesday, January 27, 2016 3:29 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout

Yes, -layout is broken.  Thanks for pointing this out.  I just finished doing -layout on 15 bundles and burned the final archive discs for our release (without actually looking at the folder to see as you reported that the files are not actually there.  This is a big problem for us.   Must go talk to the boss.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: Wednesday, January 27, 2016 3:24 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout 

Right, but a layout is designed for a user to generate an offline install.  If they are doing a Layout, the old default was the CurrentDirectory, which now should be the original bundle location.  I have confirmed one can override this by providing an explicit path, but this is an unexpected and undesirable change in behavior.

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Steven Ogilvie
Sent: Wednesday, January 27, 2016 3:21 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: Re: [wix-devs] Clean room defect with 3.11.2 - /layout [P]

Yes

I ran it from here: 
C:\Temp\admin>TITUSIlluminateSetup.exe /layout

It copied the install package to: C:\Users\steven.ogilvie\AppData\Local\Temp\{633334F0-6A6E-47E4-950C-135018F23862}\.cr

>From the log file:
Burn v3.10.2.2522, Windows v6.1 (Build 7601: Service Pack 1), path: C:\Users\STEVEN~1.OGI\AppData\Local\Temp\{95591265-5AD4-41FD-A0B8-8C402CC0CBA7}\.cr\TITUSIlluminateSetup.exe

Steve

-----Original Message-----
From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf Of Hoover, Jacob
Sent: January-27-16 4:08 PM
To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
Subject: [wix-devs] Clean room defect with 3.11.2 - /layout

It seems layout is broken with 3.10.2, as the payload goes to the .cr instead of the original exe location.  Can anyone else confirm this?

Thanks,
Jacob

____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/ ____________________________________________________________________
WiX Toolset Developer Mailing List provided by FireGiant http://www.firegiant.com/