[wix-devs] ThmUtil Qs

[Sean Hall]

1.  It was used in wix3.  I guess we can take it out since it's not used
right now.

2.  Looks like it's safe to skip null terminating the resource "string"
before passing it to StrAllocStringAnsi.

On Mon, Oct 12, 2015 at 3:55 PM, Bob Arnson <bob at firegiant.com> wrote:

> 3. You're right. Hyperlink is limited in that the entire string is one
> link (whereas Hypertext supports multiple links and non-link text) but it
> supports normal/hover/selected fonts.
>
> OK. It survives for now.
>
> -----Original Message-----
> From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf
> Of Rob Mensching
> Sent: Monday, 12 October, 2015 16:46
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Subject: Re: [wix-devs] ThmUtil Qs
>
> 1. If it isn't used to index directly to controls (::GetDlgItem() or some
> such) then it's probably dead weight and can go.
>
> 2. As long as strings end up null-terminated, less work is good. <smile/>
>
> 3. I think one of those is more configurable (font, color, etc) than the
> other. If everything can be done with Hypertext then that's cool... but I
> remember Hypertext being horribly annoying to use if you didn't want links
> to be blue and underlined.
>
>
> -----Original Message-----
> From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf
> Of Bob Arnson
> Sent: Monday, October 12, 2015 1:21 PM
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Subject: Re: [wix-devs] ThmUtil Qs
>
> 3. Does anyone care if Hyperlink goes away, given that we have Hypertext?
>
> -----Original Message-----
> From: wix-devs [mailto:wix-devs-bounces at lists.wixtoolset.org] On Behalf
> Of Bob Arnson
> Sent: Monday, 12 October, 2015 14:21
> To: WiX Toolset Developer Mailing List <wix-devs at lists.wixtoolset.org>
> Subject: [wix-devs] ThmUtil Qs
>
> 1.       THEME_PAGE::rgdwControlIndices doesn't appear to be used, just
> maintained. (THEME_PAGE::cControlIndices is used.) Anybody feel a need to
> maintain it?
>
> 2.       ThemeLoadFromResource tries to null-terminate the resource
> "string." I see it fail (crash), which makes sense-it's read-only,
> right?-but it doesn't crash in WiX v3.x. So there's something else going
> on. That said, though I remain curious, I'm going to delete it anyway,
> since it's redundant with StrAllocStringAnsi.
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
> ____________________________________________________________________
> WiX Toolset Developer Mailing List provided by FireGiant
> http://www.firegiant.com/
>